-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: feedback is extremely slow with large monorepo #44188
Comments
Can you please share your It looks like this repository contains a large number of modules, and |
I've also attached the gopls logs[Info - 6:42:56 AM] 2021/02/10 06:42:56 go env for /workspace/gitpod (root /workspace/gitpod) (go version go version go1.15 linux/amd64) (valid build configuration = false) (build flags: []) GOINSECURE= GOCACHE=/home/gitpod/.cache/go-build GOFLAGS= GOROOT=/home/gitpod/sdk/go1.15 GOMODCACHE=/workspace/go/pkg/mod GOSUMDB=sum.golang.org GOPRIVATE= GOPROXY=https://proxy.golang.org,direct GOMOD= GONOPROXY= GOPATH=/workspace/go GO111MODULE= GONOSUMDB= |
To confirm, when you set experimentalWorkspaceModule, did you remove the workspace roots? I should've confirmed, but you have to do that to set it up correctly, otherwise there will be no change. You will also need to reload the editor after configuring that setting. Also, it looks like you're missing the |
Good point. I have set things up that way now, made sure to reload the editor and for good measure restarted
Sorry, I missed that the firs way 'round. I've attached the gzipped gopls logs with rpc.trace enabled: gopls-2021-02-10.txt.gz |
A few things I noticed in the log you shared: This error message in the This message may indicate that
Does
Do you mind sharing a log? I was actually able to use |
There hasn't been any activity on this issue for over a month, so I'm going to go ahead and close it. Please open a new issue if this problem persists. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, it does
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Opened https://github.com/gitpod-io/gitpod and tried to use gopls.
You can reproduce the exact same setup that I used by
ws-manager/pkg/manager.go
.What did you expect to see?
I expected to get timely and swift feedback on my Go code.
What did you see instead?
The feedback (auto complete, error marker) is so slow that they're virtually unusable.
I reckon this might have to do with the multitude of workspace roots, large Go files and many modules.
Build info
The text was updated successfully, but these errors were encountered: