Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add linux-arm-aws to the set of trybots #45064

Closed
cagedmantis opened this issue Mar 16, 2021 · 4 comments
Closed

x/build: add linux-arm-aws to the set of trybots #45064

cagedmantis opened this issue Mar 16, 2021 · 4 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Mar 16, 2021

As per our goals of including a trybot for any platform that can cause a release blocking issue (#29239), we will add linux-arm-aws to the set of trybots. It should be able to complete the trybot run limit of 10 minutes. These new trybots will help solve various open issues linked to host resources (#35628, #40872).

This change will require renaming the linux-arm builders to linux-arm-scaleway because there is a need to map the AWS instances to some slowbot aliases.

@golang/release @cherrymui

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Mar 16, 2021

SGTM, thanks.

As of now the old linux-arm builders don't seem to be provide much. Maybe we can consider just removing them.

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Mar 16, 2021

I would like to keep the Scaleway builders around until we no longer support Go 1.15. We used Scaleway builders to package Go 1.15 and I would like to continue using the same configuration to package the rest of Go 1.15. I can discuss it with the team today to ensure that this is a good idea.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Mar 16, 2021

Okay, thanks for the information.

@toothrot toothrot added this to Planned in Go Release Team Mar 16, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2021

Change https://golang.org/cl/303230 mentions this issue: dashboard: add linux-arm-aws to trybots

@cagedmantis cagedmantis moved this from Planned to In Progress in Go Release Team Mar 23, 2021
gopherbot pushed a commit to golang/build that referenced this issue Apr 2, 2021
This change adds linux-arm-aws to the set of trybots. The related
changes include:
- Renaming the linux-arm builder to linux-arm-scaleway.
- Adding slowbot aliases which use linux-arm-aws as the default
  builder for linux-arm builds.

Fixes golang/go#35628
Fixes golang/go#40872
Updates golang/go#45064

Change-Id: Ib49f50e03fc4f766015fdd78080b804c2784a398
Reviewed-on: https://go-review.googlesource.com/c/build/+/303230
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis cagedmantis closed this Apr 2, 2021
Go Release Team automation moved this from In Progress to Done Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants