x/tools/gopls: cannot find implementation for a particular interface in a vendored module

[ronakg]

What version of Go are you using (go version)?

$ go version
go version go1.16.5 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rogandhi/Library/Caches/go-build"
GOENV="/Users/rogandhi/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/rogandhi/go/pkg/mod"
GONOPROXY="*.cisco.com"
GONOSUMDB="*.cisco.com"
GOOS="darwin"
GOPATH="/Users/rogandhi/go"
GOPRIVATE="*.cisco.com"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.16.5/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.16.5/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.5"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/rogandhi/work/ise-go/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/f1/d20cq36s6gn1kj0vgdv855t00000gn/T/go-build226289176=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Some vendored modules are not getting parsed properly by gopls. Things like references, implementations etc for certain types don't work.

I've tried to navigate to references and implementations for these modules in both VSCode and Vim, but get the same results. I'm not able to reproduce the issue in a small project that I can post here for easy investigation. But I can provide any logs etc. as long as they don't reveal anything about the code itself.

The exact same issue is observed if I open just the vendored module in VSCode too.

[suzmue]

Thanks for filing an issue @ronakg!

What happens when you try to navigate to references? In what way is it not working?

Could you please include the gopls logs for trying to navigate to references, and the version of gopls? Instructions for collecting gopls logs in VS Code can be found here.

[ronakg]

What happens when you try to navigate to references? In what way is it not working?

When I try to get implementations for an interface, I don't get back any results. I don't get autocompletion results for some of such types as well. If I clone the vendored module separately in a different workspace, then everything works fine.

Attaching gopls server output -
gopls.log

[stamblerre]

Ah, this is actually working as intended (for now). #42527 tracks adding support for vendor directories, but I'm not yet sure how we will solve this issue. For now, we don't treat vendored packages as "workspace packages", which prevents workspace-wide features (like implementations) from working in vendor directories.

I will close this in favor of #42527.