Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: crash on pointer conversion in call to mapaccess2 [1.18 backport] #51849

Closed
gopherbot opened this issue Mar 21, 2022 · 4 comments
Closed
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 21, 2022

@ianlancetaylor requested issue #51840 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open a backport to 1.18

This is a compiler crash on valid code.

@gopherbot gopherbot added the CherryPickCandidate label Mar 21, 2022
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 21, 2022
@dmitshur dmitshur removed this from the Go1.18.1 milestone Apr 12, 2022
@dmitshur dmitshur added this to the Go1.18.2 milestone Apr 12, 2022
@mdempsky
Copy link
Member

@mdempsky mdempsky commented May 7, 2022

On #51840, it's reported that 115c3bf happened to fix this issue. I think that CL will backport cleanly to 1.18, but I think it will break -G=0 mode.

If we want to fix for 1.18, I can prepare a backport fix that doesn't break -G=0. It would be just keeping the old logic for -G=0, and the new logic for -G=3 and unified IR.

@heschi heschi removed this from the Go1.18.2 milestone May 10, 2022
@heschi heschi added this to the Go1.18.3 milestone May 10, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 10, 2022

Change https://go.dev/cl/405436 mentions this issue: [release-branch.go1.18] cmd/compile: backport fix for #51840

@heschi heschi added the CherryPickApproved label May 11, 2022
@heschi
Copy link
Contributor

@heschi heschi commented May 11, 2022

Crash on valid code. Approved.

@gopherbot gopherbot removed the CherryPickCandidate label May 11, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 25, 2022

Closed by merging e1b14f5 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 25, 2022
This CL is a manual backport of CLs 403837 and 404914 to Go 1.18.

CL 403837 was intended just as a simplification CL, but evidently it
also fixed #51840. However, for backporting to Go 1.18, the existing
logic needs to be preserved to support -G=0 mode (which still relies
on Ntype).

Fixes #51849.

Change-Id: Ib060b0bc67ecf26de8a65d5b4d2f8a65cd547517
Reviewed-on: https://go-review.googlesource.com/c/go/+/405436
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

4 participants