Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: TestHandshakeRekeyDefault failures #56981

Closed
gopherbot opened this issue Nov 29, 2022 · 2 comments
Closed

x/crypto/ssh: TestHandshakeRekeyDefault failures #56981

gopherbot opened this issue Nov 29, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && test == "TestHandshakeRekeyDefault"

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Write at 0x00c0002f4c30 by goroutine 1349:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x199
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1446 +0x216
  testing.runTests()
      /workdir/go/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1726 +0xa84
  main.main()
      _testmain.go:321 +0x2e9
==================
--- FAIL: TestHandshakeRekeyDefault (0.01s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 29, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && test == "TestHandshakeRekeyDefault"
2022-11-17 19:18 linux-amd64-race crypto@2c476679 go@14074cec x/crypto/ssh.TestHandshakeRekeyDefault (log) 
==================
WARNING: DATA RACE
Write at 0x00c0002f4c30 by goroutine 1349:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x199
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1446 +0x216
  testing.runTests()
      /workdir/go/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1726 +0xa84
  main.main()
      _testmain.go:321 +0x2e9
==================
--- FAIL: TestHandshakeRekeyDefault (0.01s)

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Nov 29, 2022
@bcmills
Copy link
Contributor

bcmills commented Nov 29, 2022

Duplicate of #56957

@bcmills bcmills marked this as a duplicate of #56957 Nov 29, 2022
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
@golang golang locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot