-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vuln/internal/vulncheck/internal/buildinfo: broken at tip #61511
Comments
The test seems to be checking for old (buggy) behavior, maybe so it can be adjusted when needed (i.e. now). Related to #61051. cc @zpavlinovic |
Found new dashboard test flakes for:
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@2eca0b1e x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@e713d6f9 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@ffd9bd7e x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
|
This looks it is fixed now, but will keep it open for a bit longer. |
The issue seems to be resolved. Closing. |
Found new dashboard test flakes for:
2023-07-18 21:48 darwin-amd64-11_0 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 darwin-amd64-12_0 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 darwin-amd64-13 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 darwin-amd64-longtest vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 darwin-amd64-nocgo vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 linux-amd64-wsl vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
2023-07-18 21:48 linux-riscv64-unmatched vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log)
|
For some reason still not known to me, this is testing the vuln repo from Jul 18th. This particular test should not be failing now. |
The date is the commit date of the vuln repo commit, not the date where the test ran, nor the main repo commit date. This is probably newer Go commit run with an older vuln commit. I think it is probably safe to call it fixed. Thanks. |
across essentially all builders starting at http://go.dev/cl/506758.
cc @golang/vulndb @cherrymui
The text was updated successfully, but these errors were encountered: