Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: handle an off-cycle Go 1.19 minor release #62076

Closed
dmitshur opened this issue Aug 16, 2023 · 6 comments
Closed

x/build/cmd/relui: handle an off-cycle Go 1.19 minor release #62076

dmitshur opened this issue Aug 16, 2023 · 6 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

We're planning to do an off-cycle Go 1.19 minor release primarily to include corrected handling of modules and workspaces that declare to need Go 1.22, as mentioned at https://go.dev/doc/toolchain.

This is the tracking issue to add temporary support to relui to issue this release, and then clean up after it is done.

CC @golang/release.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 16, 2023
@dmitshur dmitshur added this to the Unreleased milestone Aug 16, 2023
@dmitshur dmitshur self-assigned this Aug 16, 2023
@gopherbot
Copy link

Change https://go.dev/cl/520236 mentions this issue: internal/relui: add a solo Go 1.19 next minor workflow

gopherbot pushed a commit to golang/build that referenced this issue Aug 16, 2023
@dmitshur @gopherbot
internal/relui: add a solo Go 1.19 next minor workflow
a775ecf 
In general, try to reuse as much existing code as possible to do this
one off-cycle release. Pretending that it's a KindPrevMinor release
kind (rather than creating a new KindPrevPrevMinor) should do that.

My plan is to use it up to the point of "Wait for Coordinator Approval"
to pre-build, and on the target release day, up to "Wait to Announce".

At that point, we can either let it send the rare but supported
"solo minor release" communication, or, perhaps better, instead
rely on the dual workflow for the Go 1.21.1 and Go 1.20.8 minor
releases to take care of the announcement. That is, we can add
a brief sentence to the announcement email and likely not worry
too much about the tweet.

For golang/go#62076.

Change-Id: Ie0783da9d4451a91311d99ccccf2689268ef39cf
Reviewed-on: https://go-review.googlesource.com/c/build/+/520236
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/520238 mentions this issue: internal/relui, internal/task: merge KindCurrentMinor and KindPrevMinor

gopherbot pushed a commit to golang/build that referenced this issue Aug 16, 2023
@dmitshur @gopherbot
internal/relui, internal/task: merge KindCurrentMinor and KindPrevMinor
e3604e6 
Unfortunately, KindPrevMinor doesn't work for the one-off Go 1.19.x
release, because GetNextVersion(KindPrevMinor) gets the next Go 1.20.x
minor version, not the next Go 1.19.x minor version. So GetNextVersion
needs some change, or its callers do.

Almost all tasks already have access to the major version number, and
other than GetNextVersion itself, pretty much everything else treats
KindCurrentMinor and KindPrevMinor interchangeably. In fact, when relui
was just being started, we kept forgetting to handle both of them.

Instead of trying to add KindPrevPrevMinor or some 1.19-specific hack,
it seems simpler to give GetNextVersion the major explicitly and leave
only KindMinor behind.

For golang/go#62076.

Change-Id: I18c2cb76c2008949d6ac055a2ed0fa4cd3c4a32a
Reviewed-on: https://go-review.googlesource.com/c/build/+/520238
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/520355 mentions this issue: internal/task: improve TestGetNextVersion subtest names

gopherbot pushed a commit to golang/build that referenced this issue Aug 18, 2023
@dmitshur @gopherbot
internal/task: improve TestGetNextVersion subtest names
9ca59be 
TestGetNextVersion/#00, TestGetNextVersion/#1 and
so on wasn't quite what I had in mind in CL 520238.

Also simplify the -test.run flag value lookup while here.
The type we want is a string, so no need for flag.Getter.

For golang/go#62076.

Change-Id: Ie1d8125caa5f6bf4fc53e3fd9e8807dbf9608384
Reviewed-on: https://go-review.googlesource.com/c/build/+/520355
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dagood dagood mentioned this issue Aug 21, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/526215 mentions this issue: internal/task: work around no LUCI support for release-branch.go1.19

gopherbot pushed a commit to golang/build that referenced this issue Sep 6, 2023
@dmitshur @gopherbot
internal/task: work around no LUCI support for release-branch.go1.19
ed87657 
We've switched to using LUCI trybots that require release-branch.go1.20
or higher. Add a work around for one more Go 1.19 release that needs it.

For golang/go#62076.

Change-Id: I3c66f50392f4c249d2c063b8ff46423bd42a3dbe
Reviewed-on: https://go-review.googlesource.com/c/build/+/526215
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/526216 mentions this issue: internal/relui, internal/task: clean up after the 1.19 off-cycle release

@dmitshur dmitshur mentioned this issue Sep 6, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/527017 mentions this issue: internal/releasetargets: drop Go 1.19 targets

gopherbot pushed a commit to golang/build that referenced this issue Sep 8, 2023
@dmitshur @gopherbot
internal/releasetargets: drop Go 1.19 targets
422d3b0 
There won't be new Go 1.19 releases per go.dev/doc/devel/release#policy.

For golang/go#62076.
For golang/go#40561.

Change-Id: I30e09c9f47ec0006caeb67e15e03b8cdbff7c175
Reviewed-on: https://go-review.googlesource.com/c/build/+/527017
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot