Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/net/websocket: setting BinaryFrame #7350
Default PayloadType is TextFrame and there seem to be no way of setting it to BinaryFrame. https://code.google.com/p/go/source/browse/websocket/hybi.go?repo=net#346 I'm not too sure what the fix would be, but in my case modifying that line 346 worked...
…pherJS) through a websocket connection.
We no longer maintain x/net/websocket. @dmitshur and @ledangster, there was a suggestion for that documentation update but we instead recommend alternatives:
Do you have a reference for that? I'm asking because I don't know.
This is not to suggest that this package is maintained actively or in an exemplary manner, but as far as I can see, #18152 is still in open state with NeedsDecision state, which suggests to me it's still under maintenance.
I don't see a benefit in closing this issue (and not the 12 other open issues with "x/net/websocket:" prefix) until there's some sort of resolution to #18152, given that this issue properly titled/labeled and it is tracking a valid problem in the
Basically #18152 (comment).
It may not be worded explicitly, but it effectively means that.
Stress on "more actively maintained". Which indirectly means, this is not well-maintained.
AFAIU, #18152 is about doing something about the fact that it's unmaintained, by merging with gorilla/websocket or something else. But it is clear that the repo in its current state is unmaintained, and users are encouraged to look somewhere else.