Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: SetKeepAlivePeriod doesn't work well on Solaris #8683

Closed
mikioh opened this issue Sep 9, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@mikioh
Copy link
Contributor

commented Sep 9, 2014

Because it uses wrong options. The changeset 19240:4ab152b54171 is completely wrong.
@gopherbot

This comment has been minimized.

Copy link

commented Sep 10, 2014

Comment 1:

CL https://golang.org/cl/136480043 mentions this issue.
@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2014

Comment 2:

This issue was closed by revision f956740.

Status changed to Fixed.

@mikioh mikioh added fixed labels Sep 11, 2014

@golang golang locked and limited conversation to collaborators Jun 25, 2016

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018

net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.