-
Notifications
You must be signed in to change notification settings - Fork 492
Conversation
Signed-off-by: Wei Fu <fhfuwei@163.com>
This PR (HEAD: 096da70) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/lint/+/108995 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/108995. |
Message from Brad Fitzpatrick: Patch Set 1: Well, golang.org/x/lint/golint is a 404, so I doubt this is correct (yet?). Please don’t reply on this GitHub thread. Visit golang.org/cl/108995. |
Message from Wei Fu: Patch Set 1:
@brad, yes. but the github.com/golang/lint/golint uses golang.org/x/lint as remote package. Ping @andrew. We have workaround for this in #397. Could you please take a look? Thanks Please don’t reply on this GitHub thread. Visit golang.org/cl/108995. |
Message from Brad Fitzpatrick: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/108995. |
Update the command to `go get -u golang.org/x/lint/golint` to make it consistent with `README.md'. Change-Id: I0e20881d34a9689577d9c9f5ad74008782695c95 GitHub-Last-Rev: 096da70 GitHub-Pull-Request: #398 Reviewed-on: https://go-review.googlesource.com/108995 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This PR is being closed because golang.org/cl/108995 has been merged. |
Update the command to
go get -u golang.org/x/lint/golint
to make it consistent with `README.md'.