Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

CONTRIBUTING.md: update the command. #398

Closed
wants to merge 1 commit into from

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Apr 24, 2018

Update the command to go get -u golang.org/x/lint/golint to make it consistent with `README.md'.

Signed-off-by: Wei Fu <fhfuwei@163.com>
@gopherbot
Copy link

This PR (HEAD: 096da70) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/108995 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/108995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

Well, golang.org/x/lint/golint is a 404, so I doubt this is correct (yet?).


Please don’t reply on this GitHub thread. Visit golang.org/cl/108995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Wei Fu:

Patch Set 1:

Patch Set 1:

Well, golang.org/x/lint/golint is a 404, so I doubt this is correct (yet?).

@brad, yes. but the github.com/golang/lint/golint uses golang.org/x/lint as remote package.

Ping @andrew. We have workaround for this in #397. Could you please take a look? Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/108995.
After addressing review feedback, remember to publish your drafts!

@brad
Copy link

brad commented Apr 24, 2018

@fuweid I think you mean @bradfitz

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/108995.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 24, 2018
Update the command to `go get -u golang.org/x/lint/golint` to make it consistent with `README.md'.

Change-Id: I0e20881d34a9689577d9c9f5ad74008782695c95
GitHub-Last-Rev: 096da70
GitHub-Pull-Request: #398
Reviewed-on: https://go-review.googlesource.com/108995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/108995 has been merged.

@gopherbot gopherbot closed this Apr 24, 2018
@fuweid fuweid deleted the update_CONTRIBUTING_md branch April 27, 2018 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants