This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Skip rewriting output files if unchanged #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
sodul
force-pushed
the
rewrite
branch
2 times, most recently
from
47afa5e
to
6711b2a
Compare
|
@codyoss let me know if you need anything else to review here. Thank you! |
|
Gentle ping @codyoss This is a simple change that has a positive impact on IDEs and other tools that rescan on changed files. |
codyoss
reviewed
Aug 11, 2022
When running mockgen with the output option this checks if the existing file content already exists and skips writing if there is nothing to change. This will help reduce i/o when changing lots of files, but also reduce the re-indexing triggering in IDEs. Solves golang#604
codyoss
suggested changes
Aug 12, 2022
bradleygore
added a commit
to bradleygore/gomock
that referenced
this pull request
Oct 14, 2022
skip rewriting output files if unchanged (golang#626)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running mockgen with the output option this checks if the existing file content already exists and skips writing if there is nothing to change.
This will help reduce i/o when changing lots of files, but also reduce the re-indexing triggering in IDEs.
Solves #604