Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket: Add nhooyr.io/websocket to the deprecation message #51

Closed
wants to merge 1 commit into from
Closed

websocket: Add nhooyr.io/websocket to the deprecation message #51

wants to merge 1 commit into from

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Sep 4, 2019 •
edited
Loading

My library is a well maintained alternative as well and is easier to transition to thanks to the NetConn wrapper.

Updates golang/go#18152

@nhooyr nhooyr changed the title net/websocket: Add nhooyr.io/websocket to the deprecation message websocket: Add nhooyr.io/websocket to the deprecation message Sep 4, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 3ca4485) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/193217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: f4b28d6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/193217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: b0f7beb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/193217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@nhooyr nhooyr mentioned this pull request Sep 21, 2019
Open
@gopherbot
Copy link
Contributor

This PR (HEAD: dedba0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/193217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193217.
After addressing review feedback, remember to publish your drafts!

@nhooyr
websocket: Add nhooyr.io/websocket to the deprecation message
0ae267b 
nhooyr.io/websocket is another actively maintained and featureful library.

Updates #18152
@gopherbot
Copy link
Contributor

This PR (HEAD: 0ae267b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/193217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Anmol Sethi:

Patch Set 7:

Patch Set 6:

(2 comments)

Fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193217.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 21, 2019
@nhooyr @bradfitz
websocket: Add nhooyr.io/websocket to the deprecation message
1a5e07d 
 My library is a well maintained alternative as well and is easier to transition to thanks to the [NetConn](https://godoc.org/nhooyr.io/websocket#NetConn) wrapper.

Updates golang/go#18152

Change-Id: Iff9addebcee4f39dbd9f015d0fbe7613e4ee45dd
GitHub-Last-Rev: 0ae267b
GitHub-Pull-Request: #51
Reviewed-on: https://go-review.googlesource.com/c/net/+/193217
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/193217 has been merged.

@gopherbot gopherbot closed this Sep 21, 2019
@nhooyr nhooyr deleted the nhooyr-websocket branch September 21, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhooyr @gopherbot @googlebot