-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang/pkgsite: improve hostname verification to ensure origin before setting cookie #88
Conversation
Updates frontend to only check for `[.]go.dev`
This PR (HEAD: 61741be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/574655. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Aviv Keller: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Jonathan Amsterdam: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from David Chase: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Aviv Keller: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Carlos Amedee: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574655. |
… setting cookie Updates frontend to only check for `*.go.dev` / `go.dev`, instead of `*go.dev` Change-Id: I1460aa69f2f032f9a098a22651586bb737927453 GitHub-Last-Rev: 61741be GitHub-Pull-Request: #88 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/574655 Reviewed-by: Aviv Keller <telavivkeller@gmail.com> TryBot-Bypass: Jonathan Amsterdam <jba@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
This PR is being closed because golang.org/cl/574655 has been merged. |
Updates frontend to only check for
*.go.dev
/go.dev
, instead of*go.dev