Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delve rewind/replay and core dump support #1507

Closed
wants to merge 1 commit into from

Conversation

brittblak4
Copy link

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: frob the quux before blarfing
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes golang/vscode-go#1234 or Updates golang/vscode-go#1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo, you can use the owner/repo#issue_number syntax:
    Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

@google-cla
Copy link

google-cla bot commented May 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label May 18, 2021
@lggomez
Copy link
Contributor

lggomez commented May 22, 2021

Sorry, I made an earlier comment which I deleted. There is an original implementation on this PR at #89 but it is deprecated, is this PR derived from the original one for update reasons? That effort is deprecated as that functionality is being moved to the dlv-dap server

For the ongoing effort see its corresponding PR at #1268

@hyangah
Copy link
Contributor

hyangah commented Aug 10, 2021

Thanks for the PR. As @lggomez said, the dev work is happening in go-delve/delve repo instead as we moved the default debug adapter to dlv dap.
@lggomez added the core/replay mode support which will be available in v0.27.1. Closing.

p. Work to support Record&Replay in mode=debug/test/exec is still a work in progress.

@hyangah hyangah closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants