Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support check.v1 Test Suites #1494

Closed
wants to merge 4 commits into from
Closed

Support check.v1 Test Suites #1494

wants to merge 4 commits into from

Conversation

jcalabro
Copy link

Fixes #111

This PR roughly follows the code snippet outlined here: microsoft/vscode-go#1921 (comment) to ensure that codelens is available for not just stretchr/testify, but also gopkg.in/check.v1.

The associated issue (#111) and linked issues discuss support for other testing suites as well (#228), however I did not add them as I am not familiar with them.

Taking that in to consideration, I'd love comments on:

  • Is this a reasonable approach in general? It does change a few functions to by async, but the logical flow remains the same as all callers simply await as well.
  • Should we spend the time to integrate a more flexible system for adding/updating testing packages? That would probably be outside the scope of this PR, but if that approach is preferred, that's pretty reasonable.

Also, this is my first contribution, and I believe I've followed the contributing guide, but please let me know if there is anything I can do to make this smoother! Thanks!

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 11, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: e54fc9b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/318689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b94e7efa-d6e6-4a3d-a752-19d65a51011c


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b94e7efa-d6e6-4a3d-a752-19d65a51011c


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b94e7efa-d6e6-4a3d-a752-19d65a51011c


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b94e7efa-d6e6-4a3d-a752-19d65a51011c


Please don’t reply on this GitHub thread. Visit golang.org/cl/318689.
After addressing review feedback, remember to publish your drafts!

@jcalabro jcalabro closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code lens: support running and debugging tests that use http://labix.org/gocheck
2 participants