-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support check.v1 Test Suites #1494
Conversation
This PR (HEAD: e54fc9b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/318689 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from Hyang-Ah Hana Kim: Patch Set 1: Run-TryBot+1 (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from kokoro: Patch Set 1: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from kokoro: Patch Set 1: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from Hyang-Ah Hana Kim: Patch Set 1: Run-TryBot+1 (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from kokoro: Patch Set 1: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Message from kokoro: Patch Set 1: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/318689. |
Fixes #111
This PR roughly follows the code snippet outlined here: microsoft/vscode-go#1921 (comment) to ensure that codelens is available for not just stretchr/testify, but also gopkg.in/check.v1.
The associated issue (#111) and linked issues discuss support for other testing suites as well (#228), however I did not add them as I am not familiar with them.
Taking that in to consideration, I'd love comments on:
Also, this is my first contribution, and I believe I've followed the contributing guide, but please let me know if there is anything I can do to make this smoother! Thanks!