Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: no deterministic note as 1.20 does rand seed #194

Closed
wants to merge 1 commit into from

Conversation

crisman
Copy link
Contributor

@crisman crisman commented Feb 20, 2023

With go 1.20 "math/rand package now automatically seeds the global random number generator" (https://go.dev/doc/go1.20#math/rand) and we do not need the appengine specific note that the Go Playground environment for the tour programs is deterministic.

As the note is specific to the appengine version (i.e. it is already not shown in the Go offline tour) it should be fine to just remove the text.

Fixes golang/tour#1448

With go 1.20 "math/rand package now automatically seeds the global random
number generator" (https://go.dev/doc/go1.20#math/rand) and we do not need
the appengine specific note that the Go Playground environment for the tour
programs is deterministic.

As the note is specific to the appengine version (i.e. it is already not shown
in the Go offline tour) it should be fine to just remove the text.

Fixes golang/tour#1448
@gopherbot
Copy link
Contributor

This PR (HEAD: b27bc7b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/469575 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/469575.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/469575.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/469575.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/469575.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 22, 2023
With go 1.20 "math/rand package now automatically seeds the global random number generator" (https://go.dev/doc/go1.20#math/rand) and we do not need the appengine specific note that the Go Playground environment for the tour programs is deterministic.

As the note is specific to the appengine version (i.e. it is already not shown in the Go offline tour) it should be fine to just remove the text.

Fixes golang/tour#1448

Change-Id: Ice84497dbe95c5e3e89fec2d44d4cb74bc2dd5be
GitHub-Last-Rev: b27bc7b
GitHub-Pull-Request: #194
Reviewed-on: https://go-review.googlesource.com/c/website/+/469575
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/469575 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tour: not deterministic rand number as noted in the tour description
2 participants