-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_content: fix markdown styling with dark theme under /src #269
Conversation
This PR (HEAD: b7c48fb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/553957. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
This adds a template for markdown files under the go.dev/src path Font color is set by a css variable under an Article selector. The previous implementation did apply the Article class to pages under the /src path. By creating a default template pages will respect theme font colors. Fixes golang/go#64929
b7c48fb
to
f20f3c8
Compare
This PR (HEAD: f20f3c8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/553957. Important tips:
|
Message from Ben Dover: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Robert Findley: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-01-08T23:50:04Z","revision":"186846d84d9488cf2ab555ca888d969278f30713"} Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Robert Findley: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Robert Findley: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Robert Findley: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-01-11T22:05:34Z","revision":"186846d84d9488cf2ab555ca888d969278f30713"} Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Robert Findley: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/553957. |
This adds a template for markdown files under the go.dev/src path Font color is set by a css variable under an Article selector. The previous implementation did apply the Article class to pages under the /src path. By creating a default template pages will respect theme font colors. Fixes golang/go#64929 Change-Id: Icc8e1866056553eaa9b2c2569e2c34cb9fb7fda5 GitHub-Last-Rev: f20f3c8 GitHub-Pull-Request: #269 Reviewed-on: https://go-review.googlesource.com/c/website/+/553957 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This PR is being closed because golang.org/cl/553957 has been merged. |
- the fix uses the same idea in fix golang#269
This adds a template for markdown files under the go.dev/src path
Font color is set by a css variable under an Article selector.
The previous implementation did apply the Article class to pages
under the /src path.
By creating a default template pages will respect theme font colors.
Fixes golang/go#64929