-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #14
Comments
related, perhaps: |
@thegtproject @syncore thank you for reporting the issue!
but it doesn't work with |
Thank you and thank you for this useful tool! I was doing some testing locally, and managed to get it to work following issue #91 in the color library linked above. I am not sure if it breaks For reference, the modifications I made (there might be better ways to do this, but I was curious to see if I could get it to work at all): changed fmt.Printf in the printLinterConfigs function at golangci-lint/blob/master/pkg/commands/linters.go:24 to:
and doing the same in the executeLinters function at golangci-lint/blob/master/pkg/commands/linters.go:51
as well as similar changes in golangci\golangci-lint\pkg\printers\text.go:
|
#14: support color output on windows
@syncore thank you, we fixed by the same way. |
@golangci tested. looks good on my end. thanks |
Console painting issues for windows, e.g.
The text was updated successfully, but these errors were encountered: