feat: add reuseconn linter

.golangci.reference.yml

@@ -2052,6 +2052,7 @@ linters:
     - predeclared
     - promlinter
     - reassign
+    - reuseconn
     - revive
     - rowserrcheck
     - scopelint
@@ -2160,6 +2161,7 @@ linters:
     - predeclared
     - promlinter
     - reassign
+    - reuseconn
     - revive
     - rowserrcheck
     - scopelint

go.mod

@@ -187,3 +187,5 @@ require (
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
 )
+
+require github.com/atzoum/reuseconn v0.1.0 // indirect

pkg/golinters/reuseconn.go

@@ -0,0 +1,17 @@
+package golinters
+
+import (
+	"github.com/atzoum/reuseconn/reuseconn"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewReuseconn() *goanalysis.Linter {
+	return goanalysis.NewLinter(
+		"reuseconn",
+		"checks whether HTTP response body is consumed and closed properly in a single function",
+		[]*analysis.Analyzer{reuseconn.Analyzer},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeWholeProgram)
+}

pkg/lint/lintersdb/manager.go

@@ -715,6 +715,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			ConsiderSlow().
 			WithURL("https://github.com/mgechev/revive"),
 
+		linter.NewConfig(golinters.NewReuseconn()).
+			WithSince("v1.51.0").
+			WithLoadForGoAnalysis().
+			WithPresets(linter.PresetPerformance, linter.PresetBugs).
+			WithURL("https://github.com/atzoum/reuseconn"),
+
 		linter.NewConfig(golinters.NewRowsErrCheck(rowserrcheckCfg)).
 			WithSince("v1.23.0").
 			WithLoadForGoAnalysis().

test/testdata/reuseconn.go

@@ -0,0 +1,26 @@
+//golangcitest:args -Ereuseconn
+package testdata
+
+import (
+	"io"
+	"io/ioutil"
+	"net/http"
+)
+
+func BodyNotDisposedInSingleFunction() {
+	resp, _ := http.Get("https://google.com") // want "response body must be disposed properly in a single function read to completion and closed"
+	_, _ = ioutil.ReadAll(resp.Body)
+	resp.Body.Close()
+}
+
+func BodyDisposedInSingleFunction() {
+	resp, _ := http.Get("https://google.com")
+	disposeResponse(resp)
+}
+
+func disposeResponse(resp *http.Response) {
+	if resp != nil && resp.Body != nil {
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}
+}