Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: replace raw loops with funcs from slices and maps #4299

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Jan 4, 2024

This PR replaces raw loops with functions from slices and maps packages. By doing this, we are simplifying our code base, enhancing readability, and improving maintainability.

golang/exp@dd950f8...be819d1

@alexandear alexandear force-pushed the replace-loop-to-maps-contains branch from 80af1a6 to d92aea5 Compare January 4, 2024 20:11
@ldez ldez self-requested a review January 4, 2024 21:06
@ldez ldez added the topic: cosmetic changes contain cosmetic improvements label Jan 4, 2024
@ldez ldez force-pushed the replace-loop-to-maps-contains branch from 1ffb761 to bfda790 Compare January 4, 2024 21:28
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slices has been added to the std but maps hasn't been moved to the std and the package has no changes for 2 years.
So maybe at some point, we will remove maps.

@ldez ldez merged commit 521a676 into golangci:master Jan 4, 2024
12 checks passed
@alexandear alexandear deleted the replace-loop-to-maps-contains branch January 4, 2024 21:56
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants