-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sort-order option #4467
Conversation
30105a5
to
eaf0a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
Thank you for adding this 🙏 Being able to sort by more than just With a stable sort order, its easier to assess changes to reported issues between versions, configuration changes etc by performing a simple diff between reports. Without this, a significant number of issues are out of order between reports, making for a lot of noise in assessing the change. |
I'm happy if you are happy about this feature ❤️ |
Allows to change the sort order of the results.
This PR allows sorting by linter name, severity, and file information (file path, line, and column).
I still don't really understand the need behind this, but I found a "generic" way to do it, so I did it 🤷
By "generic" I mean an option not specific (like
--sort-results-by-linter
) and which can evolve without breaking changes (we can add more order types).Demo
No sorting:
Sort only based on file (default):
Sort only based on linter name:
Fixes #4197