-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: err113 analyzer name #4567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
bug
Something isn't working
linter: update
Update the linter implementation inside golangci-lint
labels
Mar 24, 2024
ldez
changed the title
fix: err113 and mnd analyzer names
fix: err113 and gomnd analyzer names
Mar 24, 2024
ldez
force-pushed
the
fix/analyzer-names
branch
from
March 24, 2024 13:07
858bd18
to
d38c49e
Compare
bombsimon
reviewed
Mar 24, 2024
ldez
changed the title
fix: err113 and gomnd analyzer names
feat: err113 and gomnd analyzer names
Mar 24, 2024
ldez
added
enhancement
New feature or improvement
and removed
bug
Something isn't working
labels
Mar 24, 2024
ldez
force-pushed
the
fix/analyzer-names
branch
from
March 24, 2024 17:15
d38c49e
to
82a623c
Compare
ldez
changed the title
feat: err113 and gomnd analyzer names
feat: fix err113 analyzer name, replace gomnd by mnd
Mar 24, 2024
ldez
changed the title
feat: fix err113 analyzer name, replace gomnd by mnd
fix: err113 analyzer name
Mar 24, 2024
ldez
force-pushed
the
fix/analyzer-names
branch
from
March 24, 2024 17:54
82a623c
to
ab9d034
Compare
ldez
added
bug
Something isn't working
and removed
enhancement
New feature or improvement
labels
Mar 24, 2024
bombsimon
approved these changes
Mar 24, 2024
Antonboom
approved these changes
Mar 25, 2024
Antonboom
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block this due to #4572 (comment)
alexandear
reviewed
Mar 25, 2024
alexandear
approved these changes
Mar 25, 2024
Antonboom
approved these changes
Mar 26, 2024
ldez
force-pushed
the
fix/analyzer-names
branch
from
March 28, 2024 19:52
6b4ea7f
to
dcb0586
Compare
ldez
added
enhancement
New feature or improvement
and removed
bug
Something isn't working
labels
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or improvement
linter: update
Update the linter implementation inside golangci-lint
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a linter name is different from the analyzer name, the analyzer name is added to the report message.
In the context of err113, it's redundant.
Before
With the PR