510 + 606 + 592- IE bugs. Unsupported mime issues, IE not supporting … #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base64 audio nor Wav files, Audio clipping before ending
goldfire
reviewed
Mar 16, 2017
| @@ -1479,7 +1479,6 @@ | |||
| // Remove the source or disconnect. | |||
| if (!self._webAudio) { | |||
| // Set the source to 0-second silence to stop any downloading. | |||
| sounds[i]._node.src = 'data:audio/wav;base64,UklGRigAAABXQVZFZm10IBIAAAABAAEARKwAAIhYAQACABAAAABkYXRhAgAAAAEA'; | |||
There was a problem hiding this comment.
This solves other legitimate issues and can't simply be removed.
There was a problem hiding this comment.
A better solution would be to only not run this on IE.
@fabioelia do you think that would work better?
There was a problem hiding this comment.
That is what we ended up doing in our project when we detected the browser as IE
|
Thanks for the detailed report! I'm going to merge this in and then add the base64 line back in with an IE test as suggested. |
ringcrl
pushed a commit
to ringcrl/howler.js
that referenced
this pull request
Apr 21, 2019
510 + 606 + 592- IE bugs. Unsupported mime issues, IE not supporting …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…base64 audio nor Wav files, Audio clipping before ending
Unsupported mime issues & Base 64 Issues
Eventually once all the sound nodes are used up for a howl and it starts to recycle you will see a
Audio/Video: Unknown Mime typeIssue-510https://connect.microsoft.com/IE/feedbackdetail/view/833467/internet-explorer-11-cannot-play-audio-file-with-data-in-base64
http://hodentekhelp.blogspot.com/2014/03/how-to-code-audio-file-to-run-in-html5.html
Audio Clipping
We have seen that in IE when we are dealing with HTML nodes, if there is a delay in the network this can lead to audio getting clipped. The audio maybe chunked and return a duration value that howler is using to clip the sound. Instead for the audio nodes we should watch the native 'ended' event to know that the audio has stopped playing
Dangling Event listener
IE has a set limit to the number of audio nodes that can exist at a given time. In the current library it seems that this issue still exists, that nodes are not properly being removed. It seems as though the error listener that was being removed in the
_errorListenerwas the wrong one. We listen for_errorFnfor audio error events.self._errorFn = self._errorListener.bind(self);Related Issues
Issue-510
Issue-606 May need additional logic for sprite maps
Issue-592