Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: license should be a valid SPDX license expression #763

Merged
merged 4 commits into from
May 19, 2017
Merged

fix: license should be a valid SPDX license expression #763

merged 4 commits into from
May 19, 2017

Conversation

t1st3
Copy link
Contributor

@t1st3 t1st3 commented May 14, 2017

when npm install on a fork, npm complains that license filed in package.json is not valid.

See https://docs.npmjs.com/files/package.json#license for valid license metadata.

t1st3 added 4 commits May 14, 2017 14:37
when `npm install` on a fork, npm complains that license
filed in package.json is not valid.

See https://docs.npmjs.com/files/package.json#license
for valid `license` expressions
when `npm install` on the repo or a fork, npm complains that license
field in package.json is not valid.

See https://docs.npmjs.com/files/package.json#license
for valid `license` expressions

Same applies for bower.json:
https://github.com/bower/spec/blob/master/json.md#license

Both must be a string containing a valid SPDX license identifier:
https://spdx.org/licenses/
when `npm install` on the repo or a fork, npm complains that license
field in package.json is not valid.

See https://docs.npmjs.com/files/package.json#license
for valid `license` expressions

Same applies for bower.json:
https://github.com/bower/spec/blob/master/json.md#license

More generally, both must be a string matching a vlid SPDX identifier:
https://spdx.org/licenses/
* 'master' of github.com:t1st3/howler.js:
  fix: license should be a valid SPDX license expression
  fix: license should be a valid SPDX license expression
@goldfire goldfire merged commit c88e168 into goldfire:master May 19, 2017
ringcrl pushed a commit to ringcrl/howler.js that referenced this pull request Apr 21, 2019
fix: license should be a valid SPDX license expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants