Make Sing instances more explicit on their left-hand sides
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clearer what the `Sing` instances are actually matching on. Moreover, this will be required in order to make these instances compile after [GHC#23515](https://gitlab.haskell.org/ghc/ghc/-/issues/23515) is implemented. This resolves the "`Sing` instances without explicit left-hand sides" section of #601.
RyanGlScott
force-pushed
the
explicit-sing-instances
branch
from
3903de5
to
ec38091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer what the
Singinstances are actually matching on. Moreover, this will be required in order to make these instances compile after GHC#23515 is implemented.This resolves the "
Singinstances without explicit left-hand sides" section of #601.