-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Worker Function Invocation #532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
Main changes
EvaluationContext
independent of API Gateway use case. This implies, by the time this PR is ready, at least we can say, Rib is fully independent of Golem OSS API Gateway.Now evaluation-context is
Make evaluator be able to run the invocation expressions in the Rib Expression Tree
Functions can exist anywhere in the Rib expression tree, and evaluator will execute it. This is based on an idea I got from John that I went ahead with this. Whether to disallow more than 1 function or not, I am leaving with the team.
Use double-quotes instead of single quotes (this is a decent change from tokeniser itself) to align with wasm-wave syntax. This will make sure we support all of wasm wave syntax
Allow users to form variants/enums etc which are simple identifiers until evaluation. Depending on the info in evaluation context, they can be resolved to Enum, Variant, or even function-call. It's even better to feed as much as information about types available (like a symbol table) into the execution context in future. With this PR, the door is opened for it.
@jdegoes I thought I will have at least this decent shape before we start pairing up. It's even easier to reason about what's in there, and I will be more comfortable to pair up on this branch to bring in type information and fix things.