This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
ResourceHandshake stateless #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
jiivan
commented
Mar 27, 2019
jiivan
force-pushed
the
server_shakes_hands
branch
from
edc2931
to
bd72b4e
Compare
jiivan
force-pushed
the
server_shakes_hands
branch
from
bd72b4e
to
513ed24
Compare
kmazurek
reviewed
Apr 4, 2019
golem/task/server/queue.py
Outdated
| logger.debug('send_message(%r, %r)', node_id, msg) | ||
| msg_queue.put(node_id, msg) | ||
|
|
||
| # Temporary code to immidiately initiate session |
There was a problem hiding this comment.
immidiately -> immediately, perhaps also add a FIXME if this is temporary?
golem/task/server/resources.py
Outdated
| HANDSHAKE_TIMEOUT = 20 # s | ||
| NONCE_TASK = 'nonce' | ||
|
|
||
| resource_handshakes: dict |
There was a problem hiding this comment.
Please add a type hint here.
kmazurek
reviewed
Apr 4, 2019
jiivan
force-pushed
the
server_shakes_hands
branch
from
f31e757
to
5ebf09c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4050 +/- ##
===========================================
- Coverage 88.76% 88.67% -0.09%
===========================================
Files 212 214 +2
Lines 18480 18598 +118
===========================================
+ Hits 16403 16491 +88
- Misses 2077 2107 +30 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move statefull resource hands shaking out of Session. Implement partial message queue usage along the way.
part of: #2223