Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix connection failure handler for verification #4085

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Apr 4, 2019

Fixes

2019-04-03 15:20:30 CRITICAL twisted                             
Traceback (most recent call last):
  File "C:\BuildbotWorker\buildpackage_windows\build\.venv\lib\site-packages\twisted\internet\defer.py", line 653, in _runCallbacks
  File "C:\BuildbotWorker\buildpackage_windows\build\golem\network\transport\tcpnetwork.py", line 182, in __connection_failure
  File "C:\BuildbotWorker\buildpackage_windows\build\golem\network\transport\tcpnetwork.py", line 239, in __call_failure_callback
  File "C:\BuildbotWorker\buildpackage_windows\build\golem\network\transport\tcpnetwork.py", line 197, in __connection_to_address_failure
  File "C:\BuildbotWorker\buildpackage_windows\build\golem\network\transport\tcpnetwork.py", line 239, in __call_failure_callback
TypeError: __connection_for_task_verification_result_failure() got an unexpected keyword argument 'conn_id'

@jiivan jiivan requested a review from shadeofblue April 4, 2019 10:27
@ghost ghost assigned jiivan Apr 4, 2019
@ghost ghost added the in progress label Apr 4, 2019
@jiivan jiivan changed the base branch from develop to b0.19 April 4, 2019 10:28
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #4085 into b0.19 will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            b0.19    #4085      +/-   ##
==========================================
+ Coverage   89.22%   89.27%   +0.04%     
==========================================
  Files         205      205              
  Lines       18433    18435       +2     
==========================================
+ Hits        16446    16457      +11     
+ Misses       1987     1978       -9

@jiivan jiivan changed the title Fix connectaion failure handler for verification Fix connection failure handler for verification Apr 4, 2019
@jiivan jiivan requested review from maaktweluit and removed request for shadeofblue April 5, 2019 10:30
@shadeofblue shadeofblue merged commit 116015a into b0.19 Apr 10, 2019
@ghost ghost removed the in progress label Apr 10, 2019
@shadeofblue shadeofblue deleted the b0.19-final_verification_failure branch April 10, 2019 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants