This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Improved crop file detection in Blender verifier #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Improves the logic for finding crop files by looking for files with the expected Blender output format in cases when the original path does not point to an existing file.
kmazurek
force-pushed
the
fix/jpeg-integration-test
branch
from
2633413
to
78ddd7a
Compare
nieznanysprawiciel
approved these changes
May 14, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4176 +/- ##
==========================================
- Coverage 88.51% 88.5% -0.02%
==========================================
Files 216 216
Lines 18788 18788
==========================================
- Hits 16630 16628 -2
- Misses 2158 2160 +2 |
shadeofblue
reviewed
May 14, 2019
apps/blender/resources/images/entrypoints/scripts/verifier_tools/verificator.py
Outdated
Show resolved
Hide resolved
shadeofblue
reviewed
May 14, 2019
apps/blender/resources/images/entrypoints/scripts/verifier_tools/file_extension/types.py
Outdated
Show resolved
Hide resolved
shadeofblue
approved these changes
May 14, 2019
|
@zakaprov think you can also remove the skip line now: |
|
@maaktweluit Good catch, I'll change that once the updated verifier Docker image is published. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3989
Improves the logic for finding crop files by looking for files with the
expected Blender output format in cases when the original path does not
point to an existing file.