This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Failing transcoding tests should not delete intermediate files #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing them every time
- Lots of other things will fail if we just return None here and mypy can see that. Let's just fail earlier.
…idthxheight present but they're identical
…sible(), fuzzy_int_if_possible()
…atReport.build() and put results for each file in a separate subdirectory
…_for_transcoding()
- The extension was not stripped correctly from the input file - In some cases there were two dots before the output file name
…nt even if only one of the values is fuzzy
…c in input column names - This way sorting works better for the codec change test. Results with the same codec/container but different resolutions get grouped together.
… of the explicitly specified task options in the table column headers - This makes it possible to for example specify a different resolution for each file in codec change test and still have the results in a single column. Otherwise each resolution gets its own column.
… one column for each tested parameter combination
… make possible to pass also args and kwargs
…l tests have this decorator
…irs_on_failed_test-> remove_temporary_dirtree_if_test_passed
nieznanysprawiciel
approved these changes
Jun 14, 2019
Codecov Report
@@ Coverage Diff @@
## CGI/transcoding/master #4316 +/- ##
=======================================================
Coverage 88.52% 88.52%
=======================================================
Files 217 217
Lines 18804 18804
=======================================================
Hits 16646 16646
Misses 2158 2158 |
nieznanysprawiciel
changed the base branch from
enhanced-transcoding-integration-tests-with-ffprobe-report
to
CGI/transcoding/master
…should-not-delete-intermediate-files
nieznanysprawiciel
deleted the
failing-transcoding-tests-should-not-delete-intermediate-files
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes several issues with the
@dont_remove_dirs_on_failed_testdecorator found by @pawelkisielewicz:parameterizedbecause it does not pass its arguments down the line and hides the name of the wrapped function.Dependencies
This pull request is based on #4249. Technically, it could work directly on
CGI/transcoding/masterbut this would require solving some conflicts and rebasing #4249 on it after that.NOTE: I have set the base branch of this pull request to
enhanced-transcoding-integration-tests-with-ffprobe-report(#4249) rather thanCGI/transcoding/master. Please remember to change the base branch back toCGI/transcoding/masterbefore you merge.