This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Move benchmarks from TaskComputer to TaskServer #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
taskcomputer_refactor
branch
from
18000a0
to
373fd4d
Compare
Wiezzel
force-pushed
the
taskcomputer_refactor
branch
from
373fd4d
to
631a8ca
Compare
Wiezzel
changed the title
Krigpl
approved these changes
Jul 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4398 +/- ##
===========================================
- Coverage 88.4% 88.38% -0.02%
===========================================
Files 224 224
Lines 19889 19882 -7
===========================================
- Hits 17583 17573 -10
- Misses 2306 2309 +3 |
|
@maaktweluit Hey, it's waiting for your review! |
maaktweluit
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
LGTM!
Thanks for the heads up @Wiezzel think i missed the review request email :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.