This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Windows docker ports #4428
Merged
Windows docker ports #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is not time-consuming so it can be performed in the calling thread instead of being deferred to another thread. Actually, this is a workaround for integration tests failing on Windows. For some reason if database was used in another thread (as it happened before this change) the unit test cleanup would fail because "The golem.db is used by another process and cannot be removed".
Wiezzel
force-pushed
the
windows_docker_ports
branch
from
3d2bf3c
to
45cd524
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4428 +/- ##
===========================================
+ Coverage 88.38% 88.45% +0.06%
===========================================
Files 224 224
Lines 19868 19847 -21
===========================================
- Hits 17561 17555 -6
+ Misses 2307 2292 -15 |
mfranciszkiewicz
approved these changes
Jul 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.