This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Stop Golem from crashing on benchmark failure #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplebanski
requested review from
etam,
mfranciszkiewicz,
shadeofblue and
ederenn
|
A command line fix for crashing GLambda app:
|
|
@mplebanski We should also disable the environment. That could be done with |
mplebanski
force-pushed
the
mplebanski-patch-benchmark-crashing
branch
from
349ff5e
to
41b7608
Compare
shadeofblue
approved these changes
Jul 10, 2019
Codecov Report
@@ Coverage Diff @@
## b0.20 #4449 +/- ##
==========================================
+ Coverage 88.32% 88.33% +0.01%
==========================================
Files 223 223
Lines 19783 19784 +1
==========================================
+ Hits 17474 17477 +3
+ Misses 2309 2307 -2 |
|
I moved the check to separate method and added FileNotFoundError exception handling. |
mfranciszkiewicz
approved these changes
Jul 10, 2019
mplebanski
force-pushed
the
mplebanski-patch-benchmark-crashing
branch
from
2b8482d
to
b2a74a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rationale is that Golem should not crash on a failed benchmark. Ideally it should disable the app for this particular run. Since this is not straightforward to add I propose this PR which sets app's performance to 0. It will at least stabilize startup behavior.
The context is GLambda's secure runtime for docker - gVisor, randomly crashing due to problems with permissions on
/sys/fs/cgroup/cpuset/docker/cpuset.cpu. We are probably hitting issue described here. From my trials one such cpuset mask refresh is e.g. runningdocker run -it --cpuset-cpus=0 some_image, although I'm not sure if it always works.