This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
New subtasks count limit #4788
Merged
New subtasks count limit #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etam
force-pushed
the
new_subtasks_count_limit
branch
from
5be056c
to
6ba5340
Compare
etam
force-pushed
the
new_subtasks_count_limit
branch
4 times, most recently
from
c3ca94a
to
03a3104
Compare
etam
force-pushed
the
new_subtasks_count_limit
branch
from
03a3104
to
ad1bd1e
Compare
|
@shadeofblue Do we want this in b0.21 (#4003 is labeled for this release), or develop (because I think it's quite significant change)? |
|
@etam develop it should be, then |
Codecov Report
@@ Coverage Diff @@
## develop #4788 +/- ##
==========================================
+ Coverage 89.33% 90.24% +0.9%
==========================================
Files 216 210 -6
Lines 20100 19633 -467
==========================================
- Hits 17957 17718 -239
+ Misses 2143 1915 -228 |
mdtanrikulu
approved these changes
Oct 15, 2019
magdasta
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskDefinition.optimize_total, which seems to be unused and quite vague.comp.task.subtasks.countrpc call for good this time (see Optimal subtask count RPC implemented golem-electron#464)