+ calculate max usage helper #4840
Conversation
| @@ -7,7 +7,7 @@ | |||
| from golem.marketplace.pooling_marketplace import\ | |||
| RequestorPoolingMarketStrategy | |||
| from golem.task import timer | |||
| from golem.task.taskkeeper import compute_subtask_value | |||
| from golem.task.helpers import calculate_subtask_amount | |||
There was a problem hiding this comment.
Maybe it's just me but "amount" here does not feel right. What was wrong with "value"?
There was a problem hiding this comment.
in programming context, value has a different connotation and obviously, may refer to something that's not necessarily a number and specifically, even if number, it may not a "monetary" number ... amount does not have such a connotation and the meaning itself may indeed be used to describe monetary quantities
if you're saying "subtask value", it could be understood as e.g. the result of the subtask or some other "value" (as in, a parameter) related to a subtask... in this respect subtask amount feels more unambiguous
There was a problem hiding this comment.
@mbenke after a tiny bit more thought, maybe just calculate_subtask_payment would be better altogether ... ?
Codecov Report
@@ Coverage Diff @@
## develop #4840 +/- ##
===========================================
+ Coverage 87.62% 89.37% +1.75%
===========================================
Files 226 227 +1
Lines 20743 20747 +4
===========================================
+ Hits 18176 18543 +367
+ Misses 2567 2204 -363 |
shadeofblue
force-pushed
the
slight-refactor-of-compute-subtask-value
branch
from
b5a8e91
to
1ae27c0
Compare
…to `calculate_subtask_payment` + `calculate_max_usage` + tests
shadeofblue
force-pushed
the
slight-refactor-of-compute-subtask-value
branch
from
1ae27c0
to
5676712
Compare
mv
compute_subtask_valueto a separatehelpersmodule and rename tocalculate_subtask_amountcalculate_max_usage