This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Update to Task API v0.23.0 #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
abort_subtask_on_timeout
branch
from
9f1b63d
to
c45f09e
Compare
maaktweluit
suggested changes
Nov 4, 2019
There was a problem hiding this comment.
LGTM!
One small comment, asked this q before and got this reply from @mfranciszkiewicz
mfranciszkiewicz
approved these changes
Nov 5, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4848 +/- ##
==========================================
- Coverage 90.13% 89.98% -0.16%
==========================================
Files 231 231
Lines 21267 21277 +10
==========================================
- Hits 19170 19147 -23
- Misses 2097 2130 +33 |
|
Please change the target branch to |
Wiezzel
force-pushed
the
abort_subtask_on_timeout
branch
from
937188a
to
608b1ba
Compare
Wiezzel
force-pushed
the
abort_subtask_on_timeout
branch
from
608b1ba
to
63e128a
Compare
|
@maaktweluit Do you accept? |
maaktweluit
approved these changes
Nov 7, 2019
Task API v0.23.0 provider AbortSubtask call which is now invoked when a subtask times out. Subtasks in verification are not timed out. Updated the Blender app to v0.6.0 which is compatible with Task API v0.23.0 Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
To avoid updating the test every time the app definition changes. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
abort_subtask_on_timeout
branch
from
63e128a
to
dd68518
Compare
|
Merging since only the Task API computation flow is affected |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task API v0.23.0 provider AbortSubtask call which is now invoked when a subtask times out. Subtasks in verification are not timed out. Updated the Blender app to v0.6.0 which is compatible with Task API v0.23.0