This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fix: use system time instead of UTC in ResourceManager.share #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
approved these changes
Nov 19, 2019
| @@ -48,7 +48,8 @@ def share( | |||
| # Missing / invalid timeouts are validated by the client. | |||
| # Don't pre-check it here and set the timeout to max int. | |||
| timeout = client_options.timeout or sys.maxsize | |||
| now = get_timestamp_utc() | |||
| # Use system time like simple-transfer does | |||
| now = datetime.now().timestamp() | |||
There was a problem hiding this comment.
shouldnt this be default_now like in the database?
There was a problem hiding this comment.
default_now returns a UTC datetime object
Codecov Report
@@ Coverage Diff @@
## b0.22 #4910 +/- ##
==========================================
+ Coverage 89.21% 89.23% +0.02%
==========================================
Files 233 233
Lines 21419 21419
==========================================
+ Hits 19108 19113 +5
+ Misses 2311 2306 -5 |
|
@maaktweluit We'd have to release a new version of simple-transfer and afaict that wasn't planned |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.