Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix: disable only new envs in EnvironmentManager.register_env #4914

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

mfranciszkiewicz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #4914 into b0.22 will increase coverage by 0.96%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           b0.22    #4914      +/-   ##
=========================================
+ Coverage   89.2%   90.16%   +0.96%     
=========================================
  Files        233      233              
  Lines      21454    21455       +1     
=========================================
+ Hits       19137    19345     +208     
+ Misses      2317     2110     -207

Copy link

@Wiezzel Wiezzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.. but shouldn't the check in line 75 disallow for re-registering?

@mfranciszkiewicz
Copy link
Contributor Author

mfranciszkiewicz commented Nov 20, 2019

@Wiezzel self._state is persistent, consecutive Golem runs will overwrite the stored value

@mfranciszkiewicz mfranciszkiewicz merged commit bede023 into b0.22 Nov 20, 2019
@mfranciszkiewicz mfranciszkiewicz deleted the task_api_env_registration branch November 20, 2019 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants