This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Task-api handle cannot_compute_task message
#4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
requested review from
jiivan,
mfranciszkiewicz,
shadeofblue and
Wiezzel
maaktweluit
force-pushed
the
mwu/b0.22/task-api-can-not-compute
branch
from
93cf9dc
to
cdcba84
Compare
| @@ -996,7 +996,13 @@ def _finish_subtask(self, subtask: RequestedSubtask, op: SubtaskOp): | |||
| ) | |||
| update_provider_efficacy(node_id, op) | |||
| if subtask_timeout is not None: | |||
| update_provider_efficiency(node_id, subtask_timeout, comp_time) | |||
| if comp_time: | |||
There was a problem hiding this comment.
At this point we have obtained computation time. Is this check here because it might be equal to 0 for some reason?
There was a problem hiding this comment.
yep, it showed n error when it was 0.
This check was copied from the old task manager
mfranciszkiewicz
approved these changes
Dec 12, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4992 +/- ##
==========================================
- Coverage 90.12% 90.08% -0.04%
==========================================
Files 233 233
Lines 21870 21873 +3
==========================================
- Hits 19710 19705 -5
- Misses 2160 2168 +8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing check for RTM, added in this PR