This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Bump golemfactory/wasm to 0.6.0 #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR bumps our Wasm sandbox to latest release 0.6.0 in Docker Hub. The corresponding changes can be found at golemfactory/sp-wasm#38. For completeness though, here's the summary of major changes to the sandbox: * port Reqc's change to VM which now makes `BINARYEN_ASYNC_COMPILATION` flag obsolete * refactors the CLI interface for the sandbox (changes `clap` for `structopt`) * refactors error handling (changes `failure` for `thiserror`)
jiivan
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## b0.22 #5089 +/- ##
========================================
+ Coverage 90% 90% +<.01%
========================================
Files 234 234
Lines 22022 22022
========================================
+ Hits 19821 19822 +1
+ Misses 2201 2200 -1 |
jiivan
suggested changes
Feb 7, 2020
jiivan
force-pushed
the
kubkon/wasm-0.6.0
branch
from
734ffc8
to
c7fd33f
Compare
|
Am I the one getting hit with the brick by accident (or was it?)? :D |
|
It's ALIIIIIVEEEE! Thanks @maaktweluit! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our Wasm sandbox to latest release 0.6.0 in Docker Hub.
The corresponding changes can be found at golemfactory/sp-wasm#38.
For completeness though, here's the summary of major changes to the sandbox:
BINARYEN_ASYNC_COMPILATIONflagobsolete
clapforstructopt)failureforthiserror)