Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

task-api - Added rpc calls for managing apps #5103

Merged
merged 9 commits into from
Feb 26, 2020
Merged

Conversation

maaktweluit
Copy link
Contributor

@maaktweluit maaktweluit commented Feb 21, 2020

Resolves #5097

Added new commands for:

golemcli debug rpc apps.list
golemcli debug rpc apps.update <app_id> <enabled_flag>
golemcli debug rpc apps.delete <app_id>

Other improvements are:

  • Moved app definition json loading to AppManager ( @mfranciszkiewicz please double check )
  • Added delete() to AppManager
  • Added missing tearDown()s in tests that use TmpDirFixture

Creates new tasks:

Copy link
Contributor

@mfranciszkiewicz mfranciszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App definition loading seems to be on par with the previous version

golem/apps/manager.py Show resolved Hide resolved
golem/apps/manager.py Show resolved Hide resolved
golem/apps/rpc.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #5103 into develop will decrease coverage by 0.19%.
The diff coverage is 87.34%.

@@            Coverage Diff             @@
##           develop    #5103     +/-   ##
==========================================
- Coverage    90.01%   89.82%   -0.2%     
==========================================
  Files          234      235      +1     
  Lines        22082    22132     +50     
==========================================
+ Hits         19877    19879      +2     
- Misses        2205     2253     +48

golem/apps/manager.py Outdated Show resolved Hide resolved
Copy link
Contributor

@etam etam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@maaktweluit maaktweluit merged commit 67da3e1 into develop Feb 26, 2020
@maaktweluit maaktweluit deleted the mwu/task-api-app-rud branch February 26, 2020 12:23
maaktweluit added a commit that referenced this pull request Mar 2, 2020
maaktweluit added a commit that referenced this pull request Mar 2, 2020
maaktweluit added a commit that referenced this pull request Mar 2, 2020
maaktweluit added a commit that referenced this pull request Mar 2, 2020
maaktweluit added a commit that referenced this pull request Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RPC call to read, update and delete task-api apps
3 participants