This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
task-api - Added rpc calls for managing apps #5103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2020
etam
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App definition loading seems to be on par with the previous version
…tent names in AppState parameters
maaktweluit
force-pushed
the
mwu/task-api-app-rud
branch
from
February 21, 2020 15:42
3c078dd
to
13d820b
Compare
maaktweluit
force-pushed
the
mwu/task-api-app-rud
branch
from
February 24, 2020 14:59
6afa350
to
2cd79c4
Compare
mfranciszkiewicz
approved these changes
Feb 25, 2020
Codecov Report
@@ Coverage Diff @@
## develop #5103 +/- ##
==========================================
- Coverage 90.01% 89.82% -0.2%
==========================================
Files 234 235 +1
Lines 22082 22132 +50
==========================================
+ Hits 19877 19879 +2
- Misses 2205 2253 +48 |
etam
reviewed
Feb 26, 2020
etam
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maaktweluit
added a commit
that referenced
this pull request
Mar 2, 2020
maaktweluit
added a commit
that referenced
this pull request
Mar 2, 2020
maaktweluit
added a commit
that referenced
this pull request
Mar 2, 2020
maaktweluit
added a commit
that referenced
this pull request
Mar 3, 2020
Task-api - Added new arguments added in #5103
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5097
Added new commands for:
Other improvements are:
AppManager
( @mfranciszkiewicz please double check )delete()
toAppManager
tearDown()
s in tests that useTmpDirFixture
Creates new tasks:
apps.list
rpc call (https://github.com/golemfactory/golem/issues/5104)apps.*
golem-client#100)