JST-924: Rearrange docs in the repo for improved maintenance #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
force-pushed
the
feature/JST-924/rental-and-exe-unit-docs
branch
from
27759f1
to
2821f67
Compare
grisha87
changed the title
SewerynKras
requested changes
Jun 21, 2024
SewerynKras
reviewed
Jun 21, 2024
grisha87
force-pushed
the
feature/JST-924/rental-and-exe-unit-docs
branch
from
4e712de
to
1e00d54
Compare
SewerynKras
reviewed
Jun 24, 2024
SewerynKras
requested changes
Jun 26, 2024
docs/UPGRADING.md
Outdated
Comment on lines
87
to
98
| > **IMPORTANT DIFFERENCE** | ||
| > | ||
| > `TaskExecutor` by default assumed that users want to run these commands in parallel, so it | ||
| > was establishing up to 5 agreements with different providers and then sent out these | ||
| > commands to different providers to leverage parallelism. | ||
| > | ||
| > With `golem-js@3.0`, when you use `oneOf` to rent resources, you are establishing one agreement | ||
| > with a single provider and the commands which you issue with `Array.map` will be executed | ||
| > sequentially by that single provider. | ||
| > | ||
| > If you want to achieve _parallel command execution_ on different providers, refer to the [Engaging with many providers at the same time](#engaging-with-many-providers-at-the-same-time) example. | ||
|
|
There was a problem hiding this comment.
Why even show this in the migration if it's fundamentally different behavior? TE users only care about parallelism. Either drop the entire Repeating commands with map of different parameter values section or use manyOf here
There was a problem hiding this comment.
Hmmmm. I guess you're right, this is more an example of the API usage than real migration. Thanks for that point of view :)
SewerynKras
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.