Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requestor agent using swagger clients #51

Merged
merged 17 commits into from
Jun 8, 2020
Merged

Requestor agent using swagger clients #51

merged 17 commits into from
Jun 8, 2020

Conversation

maaktweluit
Copy link
Contributor

@maaktweluit maaktweluit commented May 19, 2020 •
edited
Loading

Resolves #20

  • Added test/level0/mocked_client with tools to run and update the models
  • generate_mocks.sh can be ran each time the Swagger spec files change
  • Manual patches are needed to fix polymorphism and incorrect swagger definitions
  • test/level0/unix/run_mocked_requestor.sh to replace run_requestor.sh in level0 scenario

@maaktweluit maaktweluit self-assigned this May 19, 2020
@maaktweluit maaktweluit marked this pull request as draft May 19, 2020 14:31
@maaktweluit maaktweluit force-pushed the mwu/swagger-agent branch 4 times, most recently from fcb1030 to 4bb8bb8 Compare May 20, 2020 12:13
@maaktweluit maaktweluit marked this pull request as ready for review May 21, 2020 10:57
@maaktweluit maaktweluit marked this pull request as ready for review May 21, 2020 11:06
azawlocki
azawlocki reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments regarding conformance with PEP8 recommendations

model/activity/openapi_activity_client/models/activity_state.py Outdated Show resolved Hide resolved
model/market/openapi_market_client/models/proposal.py Outdated Show resolved Hide resolved
model/market/openapi_market_client/api/requestor_api.py Show resolved Hide resolved
test/level0/mocked_client/market.py Outdated Show resolved Hide resolved
test/level0/mocked_client/market.py Outdated Show resolved Hide resolved
test/level0/mocked_client/market.py Outdated Show resolved Hide resolved
test/level0/mocked_client/market.py Outdated Show resolved Hide resolved
@azawlocki azawlocki self-requested a review May 27, 2020 14:40
azawlocki
azawlocki approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azawlocki
Copy link
Contributor

Please rebase on master to see if the integration tests pass

@maaktweluit maaktweluit force-pushed the mwu/swagger-agent branch 3 times, most recently from 9ec23ec to 7788219 Compare June 1, 2020 15:06
@maaktweluit maaktweluit merged commit 44ed4b1 into master Jun 8, 2020
@maaktweluit maaktweluit deleted the mwu/swagger-agent branch June 8, 2020 12:19
@maaktweluit maaktweluit mentioned this pull request Jun 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmazurek kmazurek kmazurek approved these changes

@azawlocki azawlocki azawlocki approved these changes

Assignees

@maaktweluit maaktweluit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop Requestor side API proxies for Test Harness
3 participants
@maaktweluit @azawlocki @kmazurek