Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when i config errorBehavior = MessageHandlerErrorBehavior.ACK is invalid #187

Closed
hosea3000 opened this issue Sep 21, 2020 · 1 comment · Fixed by #190
Closed

when i config errorBehavior = MessageHandlerErrorBehavior.ACK is invalid #187

hosea3000 opened this issue Sep 21, 2020 · 1 comment · Fixed by #190

Comments

@hosea3000
Copy link

because enum MessageHandlerErrorBehavior.ACK value is 0

next code is not run as expect

image
WonderPanda added a commit that referenced this issue Oct 6, 2020
@WonderPanda
fix(rabbitmq): error behavior enum
0af5905 
start enum incrementing from 1 to prevent 0 falsiness issues

fix #187
@WonderPanda WonderPanda mentioned this issue Oct 6, 2020
Merged
WonderPanda added a commit that referenced this issue Oct 6, 2020
@WonderPanda
fix(rabbitmq): error behavior enum
6b5bc1f 
use string enum to prevent 0 falsiness issues

fix #187
@WonderPanda
Copy link
Collaborator

@syuusuke Thanks for reporting. Fix is available in @golevelup/nestjs-rabbitmq@1.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rabbitmq): error behavior enum golevelup/nestjs
2 participants
@WonderPanda @hosea3000