-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No delivery mode option on AmqpConnection.request method #719
Comments
@cs-salim It was the bare minimum setup back then, we could call it intentional/design choice but if you need to extend the available options, feel free to fill a PR that receives the partial options instead of manually pass one by one |
I opened a PR (#723) to address this as I need to provide to the |
…hem in AmqpConnection.request (#723) Added a new property named "publishOptions" to the RequestOptions interface so that the additional options available in the amqplib's Options.Publish interface can be provided when making rpc requests. Added said usage of the new property to the AmqpConnection.request method's call to this.publish. re #719
…nection.request (#723) Added a new property named "publishOptions" to the RequestOptions interface so that the additional options available in the amqplib's Options.Publish interface can be provided when making rpc requests. Added said usage of the new property to the AmqpConnection.request method's call to this.publish. re #719
AmqpConnection.request
callspublish
with a set list of parameters:https://github.com/golevelup/nestjs/blob/master/packages/rabbitmq/src/amqp/connection.ts#L402
Which doesn't let you pass other request options like delivery mode. Is this intended as a design choice or is it a bug?
The text was updated successfully, but these errors were encountered: