Misc. updates #60
Closed
Misc. updates #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnewhall
reviewed
Jun 8, 2024
| # unused | ||
| - nlreturn | ||
| - exhaustruct | ||
| - depguard | ||
| # requires go 1.22 | ||
| - copyloopvar |
There was a problem hiding this comment.
Update the golangci-lint version in the codetests.yml file. You can update the action version too.
There was a problem hiding this comment.
I actually don't want this skipped because it'll be useful one day when we get to 1.22 golang version. The linter just ignores it now.
davidnewhall
reviewed
Jun 8, 2024
| @@ -1,6 +1,6 @@ | |||
| module golift.io/xtractr | |||
|
|
|||
| go 1.19 | |||
There was a problem hiding this comment.
The library still supports version 1.19 so I'm not sure I want to do this. We use 1.21 (latest-1) to do tests in GitHub actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if you are open to 3rd-party contributions. It would be nice to see a new release.
fmt.Errorfcalls witherrors.New