Pass Context to the Run Method of a Runner #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an important update to the
daemon.Runner
interface.Since now, the
Run
method expects a mandatory context as an argument.The reason for this change is that a service implementing the
Runner
interface needs a way to listen to theDone
channel of a context, derived from the daemon's root context.Until before now it was possible by:
Ctx
With this change, a context will be automatically passed in to the
Run
method of the service.