Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookies with tempdir override, stopAndCommit used incorrect #26

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

sergeyshaykhullin
Copy link
Contributor

@sergeyshaykhullin sergeyshaykhullin commented Nov 28, 2021

  1. Cookies directory is stored in os.tempdir() always, sqlite can't open not existing file

    db = await this.getDB(filePath);

  2. stopAndCommit has swapped argument order. posting will be always false in stopLocal(options)

    async stopAndCommit(options, local= false) {

  • TODO: Bump package version

@NephilimLord
Copy link
Collaborator

  1. Cookies directory is stored in os.tempdir() always, sqlite can't open not existing file
    db = await this.getDB(filePath);
  2. stopAndCommit has swapped argument order. posting will be always false in stopLocal(options)
    async stopAndCommit(options, local= false) {
  • TODO: Bump package version

Dont understand first case.

  1. Cookies directory is stored in os.tempdir() always, sqlite can't open not existing file
    db = await this.getDB(filePath);
  2. stopAndCommit has swapped argument order. posting will be always false in stopLocal(options)
    async stopAndCommit(options, local= false) {
  • TODO: Bump package version

Thanks for edits. Will be published soon.

@NephilimLord NephilimLord merged commit 2bbf66f into gologinapp:master Dec 15, 2021
@sergeyshaykhullin
Copy link
Contributor Author

sergeyshaykhullin commented Dec 15, 2021

@NephilimLord

  1. With overridden tmpdir options, cookiesFilePath still will be os.tempdir(), but it should be tmpdir to upload profiles

stopAndCommit signature

async stopAndCommit(options, local = false)

stopAndCommit inside stopLocal call

await this.stopAndCommit(true, opts.posting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants