Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NULL reply style to allow disabling replies for handshakes #94

Merged
merged 1 commit into from
Aug 4, 2018

Conversation

pcarranza
Copy link
Collaborator

This fixes #93

As proposed the UI is:

format:
  reply_styles:
    handshake: disabled

But we can also say "nil" and "null", be mindful of the quotes because "null" is a yaml value, therefore it doesn't get interpreted as a string.

@pcarranza pcarranza requested a review from omame August 3, 2018 15:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 312

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 64.672%

Files with Coverage Reduction New Missed Lines %
remote/agent/agent.go 4 34.64%
Totals Coverage Status
Change from base Build 308: -0.2%
Covered Lines: 1232
Relevant Lines: 1905

💛 - Coveralls

@omame omame merged commit 8ec2c4d into master Aug 4, 2018
@omame omame deleted the pc/add-null-reply-style branch August 4, 2018 12:34
@omame
Copy link

omame commented Aug 4, 2018

Bah. I forgot to point out that we need a test for this.
I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable handshake globally
3 participants