New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored to remove pkg/cdn #672

Merged
merged 4 commits into from Sep 19, 2018

Conversation

Projects
None yet
4 participants
@scriptonist
Copy link
Contributor

scriptonist commented Sep 19, 2018

I believe this PR could close #657. This is my first PR and would really appreciate the early feedback.

@scriptonist scriptonist requested a review from gomods/maintainers as a code owner Sep 19, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #672 into master will decrease coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   44.24%   43.69%   -0.56%     
==========================================
  Files         105       97       -8     
  Lines        3232     3083     -149     
==========================================
- Hits         1430     1347      -83     
+ Misses       1665     1610      -55     
+ Partials      137      126      -11
Impacted Files Coverage Δ
cmd/olympus/actions/app.go 68.18% <ø> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ca414...9fdecbe. Read the comment docs.

@marwan-at-work
Copy link
Contributor

marwan-at-work left a comment

LGTM

scriptonist added some commits Sep 19, 2018

@michalpristas
Copy link
Member

michalpristas left a comment

Very nice job @scriptonist

@michalpristas michalpristas merged commit d494164 into gomods:master Sep 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment